Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config file format #60

Closed
columbarius opened this issue Oct 9, 2020 · 6 comments · Fixed by #75
Closed

Config file format #60

columbarius opened this issue Oct 9, 2020 · 6 comments · Fixed by #75
Labels
enhancement New feature or request

Comments

@columbarius
Copy link
Collaborator

To offer custom options for an outputchooser we need a config file #59 .
To make it easily readable, we should stick to a plaintext, or sway like config.
I could think of an ini like file, where each section could represent a different portal.

Is there something easy adoptable or an often used library?

@emersion
Copy link
Owner

emersion commented Oct 9, 2020

Something like an INI parser is simple enough to bundle with xdpw.

Something I've been wondering about is that we maybe want to allow compositors using xdpw to ship some default config files. This way they could customize xdpw appearance and behaviour without having to tell their users to manually copy-paste a config file. We could for instance look for $XDG_CONFIG_HOME/xdg-desktop-portal-wlr/config, then fallback to /etc/xdg-desktop-portal-wlr/$XDG_CURRENT_DESKTOP, then fallback to /etc/xdg-desktop-portal-wlr/config (or something similar).

@emersion
Copy link
Owner

emersion commented Oct 9, 2020

cc @ammen99: would that be helpful for you?

@ammen99
Copy link

ammen99 commented Oct 9, 2020

cc @ammen99: would that be helpful for you?

Wayfire by default uses all the tools made for Sway (grim/slurp/swayidle/etc) however I am pretty sure some people that are building more full-featured DEs on top of Wayfire would want to provide their own output chooser.

@columbarius
Copy link
Collaborator Author

columbarius commented Oct 10, 2020

Something like an INI parser is simple enough to bundle with xdpw.

You mean a self written one, or a dependency like iniparser?

Something I've been wondering about is that we maybe want to allow compositors using xdpw to ship some default config files. This way they could customize xdpw appearance and behaviour without having to tell their users to manually copy-paste a config file. We could for instance look for $XDG_CONFIG_HOME/xdg-desktop-portal-wlr/config, then fallback to /etc/xdg-desktop-portal-wlr/$XDG_CURRENT_DESKTOP, then fallback to /etc/xdg-desktop-portal-wlr/config (or something similar).

That would be great! Maybe also $XDG_CONFIG_HOME/xdg-desktop-portal-wlr/$XDG_CURRENT_DESKTOP.

@danshick
Copy link
Collaborator

If we start shipping a config file, which I agree is a good idea, I think it is also time to create some man pages. Right now, the only real documentation is here on the Github Wiki.

@emersion
Copy link
Owner

Opened #67 for the man page.

@danshick danshick added the enhancement New feature or request label Feb 2, 2021
emersion pushed a commit that referenced this issue Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants