Fix memory leaks #9
Conversation
main.c
Outdated
| @@ -144,6 +145,8 @@ static void seat_handle_capabilities(void *data, struct wl_seat *seat, | |||
| struct wl_pointer *wl_pointer = wl_seat_get_pointer(seat); | |||
| create_pointer(state, wl_pointer); | |||
| } | |||
|
|
|||
| wl_seat_destroy(seat); | |||
There was a problem hiding this comment.
Unfortunately I don't think we can do this. This function is called whenever seat capabilities change, this can happen at runtime (when you hotplug a mouse/keyboard for instance).
There was a problem hiding this comment.
Oh, my bad. Maybe keep a reference of it in the state and destroy it on exit then?
There was a problem hiding this comment.
There is no guarantee that there will be only one seat
There was a problem hiding this comment.
A list then? Or do you just want to leave it for now? I can remove the line from my patch.
There was a problem hiding this comment.
Yeah, a list with all the burden that comes with it: adding a new struct and allocating list elements.
This can be done in another PR if you prefer.
There was a problem hiding this comment.
Splitting it into another PR sounds like a good idea to me.
|
Thanks! |
No description provided.