Add output selection #60
Conversation
vesim987
force-pushed
the
output-selection
branch
from
834fc49 to
c25d7f7
Compare
| @@ -613,7 +635,7 @@ static void handle_global(void *data, struct wl_registry *registry, | |||
| create_output(state, wl_output); | |||
| } else if (strcmp(interface, zxdg_output_manager_v1_interface.name) == 0) { | |||
| state->xdg_output_manager = wl_registry_bind(registry, name, | |||
| &zxdg_output_manager_v1_interface, 1); | |||
| &zxdg_output_manager_v1_interface, 2); | |||
There was a problem hiding this comment.
This may break if the compositor only supports version 1. If that is a concern, I think MIN(2, version) would be better.
There was a problem hiding this comment.
I think the -o feature w/o outputs names is kinda useless. But that is a question to @emersion, if we want to keep compatibility with version 1.
There was a problem hiding this comment.
I think it's fine to bump the minimum required version to 2.
| @@ -708,7 +738,7 @@ int main(int argc, char *argv[]) { | |||
|
|
|||
| int opt; | |||
| char *format = "%x,%y %wx%h"; | |||
There was a problem hiding this comment.
If the -o option is used, should a different default format be used that includes the output name (or maybe is only the output name)?
| break; | ||
| } | ||
| } | ||
| state->result.output = output; |
There was a problem hiding this comment.
Would it make sense to set this for a rectangular selection as well? You do run into the problem of what to do if there are multiple outputs, but the simplest think would be just to pick a point, like the top left, or center of the rectangle, and use that to pick the "best" output.
There was a problem hiding this comment.
Slurp can take a predefined set of rectangles as input and limit possible selections to those rectangles (you can see this if you use the output selection example in the README).
I think the correct approach is to implement it this way, where there's no option to select anything other than the predefined rectangles which occupy each output entirely, and chosen by the rectangle the mouse is inside of.
There was a problem hiding this comment.
Looks like you can just use add_choice_box like is done here https://github.com/emersion/slurp/blob/master/main.c#L761
There was a problem hiding this comment.
limit possible selections to those rectangles
That isn't quite right. At least from me trying it out in slurp 1.2.0, it seems it just creates predefined boxes you can select with a click, but it doesn't stop you from dragging your own box.
There was a problem hiding this comment.
Hmmm, that sounds like a bug in the intended behavior, but @emersion would have to weigh in.
There was a problem hiding this comment.
No, this is intentional: the input boxes are just hints, the user can ignore the hint. I'd be fine with adding an option to prevent that.
|
As @tmccombs said, I'd prefer this to be done with the format string. We could add Then we don't even need a |
Alternative to emersion#60
Alternative to emersion#60
Alternative to emersion#60
Alternative to emersion#60
|
Superseded by #64 |
Hi, I added new mode to slurp for output selection. I had to update xdg-output-unstable-v1 to version 2, and also
_POSIX_C_SOURCEto 200809 for strdup.Right now it is setting the output name for both, point and output selection, the only difference is that in output selection it is setting the output geometry as the selection box.