Fix empty selection when user doesn't move their cursor #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slurp has this strange behavior where you start slurp and the surface is immediately fullscreen, but if your cursor is already positioned in the selection area (when you provide your own boxes) it doesn't highlight them. Worse, if you click within a selection area without moving your cursor it doesn't output the selection area you clicked on!
This PR changes that so the selection is updated on pointer enter as well as motion, allowing a selection to be immediately active when slurp starts. The first commit doesn't change anything, just rearranges some functions in main so I can use them without declaring them elsewhere. The second function does all the changes, by moving some of the motion code into
seat_update_selection
and calling it in handle_enter as well. PTAL.