-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for crosshairs #56
Conversation
@emersion Do you have any preference regarding the above? |
Use local build until this is merged: emersion/slurp#56
I think the first version you suggested (only on current output) makes the most sense! |
@emersion anything wrong with this approach? |
Sorry, I'll try to get some time to review this soon. |
@emersion ping 💐 |
Use local build until this is merged: emersion/slurp#56
I've been using this for the past year and a bit and haven't had any issues so far. Though one thing I haven't been able to fix is that the crosshair lines can disappear over white backgrounds. It seems like it should be a trivial fix so perhaps someone can chime in? |
Would you mind fixing the merge conflicts? |
@tmccombs To be honest I probably won't do it anytime soon unless it's going to get reviewed/merged since it's still working for me and I'm quite busy. I can give you write access to the fork if you want to do it. |
Resolves #45
Draws fullscreen crosshairs on the output with the cursor until a selection is started.