Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for crosshairs #56

Closed
wants to merge 3 commits into from
Closed

Conversation

ammgws
Copy link

@ammgws ammgws commented May 6, 2020

Resolves #45

Draws fullscreen crosshairs on the output with the cursor until a selection is started.

@ammgws
Copy link
Author

ammgws commented May 7, 2020

I made it so that the crosshairs are only displayed on the output with the cursor:
image

Or should it be displayed on all monitors that the crosshairs would intersect with?
image

@ammgws
Copy link
Author

ammgws commented May 21, 2020

@emersion Do you have any preference regarding the above?

ammgws added a commit to ammgws/dotfiles that referenced this pull request May 24, 2020
@y0ast
Copy link

y0ast commented May 31, 2020

I think the first version you suggested (only on current output) makes the most sense!

@ammgws
Copy link
Author

ammgws commented Nov 6, 2020

@emersion anything wrong with this approach?

@emersion
Copy link
Owner

Sorry, I'll try to get some time to review this soon.

@ammgws
Copy link
Author

ammgws commented Apr 17, 2021

@emersion ping 💐

ammgws added a commit to ammgws/dotfiles that referenced this pull request Apr 22, 2021
@ammgws
Copy link
Author

ammgws commented Aug 19, 2021

I've been using this for the past year and a bit and haven't had any issues so far.

Though one thing I haven't been able to fix is that the crosshair lines can disappear over white backgrounds.

It seems like it should be a trivial fix so perhaps someone can chime in?

@tmccombs
Copy link
Collaborator

Would you mind fixing the merge conflicts?

@ammgws
Copy link
Author

ammgws commented Sep 25, 2021

@tmccombs To be honest I probably won't do it anytime soon unless it's going to get reviewed/merged since it's still working for me and I'm quite busy. I can give you write access to the fork if you want to do it.

@tmccombs tmccombs mentioned this pull request Sep 26, 2021
@ammgws
Copy link
Author

ammgws commented Sep 28, 2021

@tmccombs I didn't realise you had write access already.

Closing in favor of #95

@ammgws ammgws closed this Sep 28, 2021
@ammgws ammgws deleted the crosshairs branch April 23, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full screen crosshairs
4 participants