-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support selection across multiple outputs #27
Conversation
Unfortunately using the output mode isn't going to work with fractional scaling. We'll need to use xdg-output to get the logical size and position. You can have a look at |
Can you rebase this PR? |
a0c40f7
to
183d348
Compare
183d348
to
c9f51ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly style issues, looks very good otherwise!
main.c
Outdated
@@ -207,7 +256,12 @@ static void create_output(struct slurp_state *state, | |||
output->scale = 1; | |||
wl_list_insert(&state->outputs, &output->link); | |||
|
|||
wl_output_add_listener(wl_output, &output_listener, output); | |||
if (state->xdg_output_manager) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't do, because the xdg-output-manager global can be advertised after all outputs. We need to create xdg-outputs and add listeners after the first roundtrip in main
(and roundtrip a second time to retrieve xdg-output properties).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check is still needed for hotplugged outputs though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I don't think we support these at all. because we don't create layer-shell surfaces for hotplugged outputs. So this would be a follow-up issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow-up issue: #32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! |
This builds on #25, sorry.
Adds support for selection across multiple outputs.