Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support selection across multiple outputs #27

Merged
merged 8 commits into from
Feb 20, 2019

Conversation

yorickvP
Copy link
Collaborator

@yorickvP yorickvP commented Feb 12, 2019

This builds on #25, sorry.

Adds support for selection across multiple outputs.

@emersion
Copy link
Owner

Unfortunately using the output mode isn't going to work with fractional scaling. We'll need to use xdg-output to get the logical size and position. You can have a look at grim to see how this can be done.

@emersion
Copy link
Owner

Can you rebase this PR?

Copy link
Owner

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly style issues, looks very good otherwise!

main.c Outdated
@@ -207,7 +256,12 @@ static void create_output(struct slurp_state *state,
output->scale = 1;
wl_list_insert(&state->outputs, &output->link);

wl_output_add_listener(wl_output, &output_listener, output);
if (state->xdg_output_manager) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't do, because the xdg-output-manager global can be advertised after all outputs. We need to create xdg-outputs and add listeners after the first roundtrip in main (and roundtrip a second time to retrieve xdg-output properties).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is still needed for hotplugged outputs though.

Copy link
Owner

@emersion emersion Feb 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I don't think we support these at all. because we don't create layer-shell surfaces for hotplugged outputs. So this would be a follow-up issue.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up issue: #32

Copy link
Owner

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there :)

Copy link
Owner

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emersion emersion merged commit a780cfa into emersion:master Feb 20, 2019
@emersion
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants