Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track seats to free them on exit #10

Merged
merged 2 commits into from
Aug 16, 2018
Merged

Track seats to free them on exit #10

merged 2 commits into from
Aug 16, 2018

Conversation

ianyfan
Copy link
Contributor

@ianyfan ianyfan commented Aug 16, 2018

Fixes memory leaks. Just added a struct to track the seats, don't know if you want to structure it differently.

Also includes a small fix to remove destroyed outputs from list.

emersion
emersion approved these changes Aug 16, 2018
View reviewed changes
Copy link
Owner

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nice destroy_output catch!

@emersion emersion merged commit 1fb1276 into emersion:master Aug 16, 2018
@emersion
Copy link
Owner

Thanks!

@ianyfan ianyfan deleted the seats branch August 16, 2018 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion emersion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianyfan @emersion