Implement the Route Manager API (RFC #1169) - #21460
Open
evoactivity wants to merge 96 commits into
Open
Conversation
Introduce a Route Manager layer between the router and route base classes so the router drives routes through a well-defined manager interface instead of calling classic Route methods directly. This decouples the router from the classic Route and is the stepping stone toward alternative route base classes and a future router. Add the manager interface, capabilities, and registration, implement a ClassicRouteManager that encapsulates today's classic Route behaviour behind it, and make router_js dispatch lifecycle, rendering, model resolution, and the classic-interop surface through the manager.
This was referenced Jun 10, 2026
evoactivity
force-pushed
the
rfc-1169-route-manager
branch
from
June 15, 2026 08:44
37bd3e6 to
7582a9f
Compare
johanrd
added a commit
to johanrd/ember.js
that referenced
this pull request
Jun 15, 2026
…s on emberjs#21460 Reverts the outlet.ts compute-ref guard to the current ember-7.0.0 behavior, demonstrating that the @model-during-willDestroy instability (emberjs#18987) still reproduces on top of the Route Manager RFC implementation (emberjs#21460). The smoke-test job's '@model stability during route transitions' tests are expected to fail here. Not for merge.
8 tasks
refactor: add manager.getRoute(bucket)
…d through `setOutletState`
Experiment/classic outlet probes
# Conflicts: # packages/@ember/-internals/glimmer/index.ts # packages/@ember/-internals/glimmer/lib/syntax/outlet.ts
| view.appendTo(this.rootElement!); | ||
| renderRootComponent(component: object) { | ||
| setRenderer(this, this.lookup('renderer:-dom') as BaseRenderer); | ||
| renderComponent(component, { into: this.rootElement!, owner: this, appendIntoTarget: true }); |
Contributor
There was a problem hiding this comment.
destruction handling?
let { destroy } = renderComponent(...);
registerDestructor(this, destroy);Subscribes to the enterPromise attached to the routeInfo
Rfc 1169 route manager drop spike
BobrImperator
force-pushed
the
rfc-1169-route-manager
branch
from
August 18, 2026 13:46
c303bca to
c5d5895
Compare
mansona
reviewed
Aug 18, 2026
| export type ModelFor<T> = T extends BaseRoute<infer V> ? V : never; | ||
|
|
||
| export interface Route<T = unknown> { | ||
| export interface BaseRoute<T = unknown> { |
Member
There was a problem hiding this comment.
do we even need this BaseRoute? this is part of a cast (somewhere) that calls getRoute() and casts (when it can't really assume the cast is right)
We need to
- check if any of this is actually used somewhere
- make it so that we don't return anything from the getRoute in new managers
- maybe remove getRoute
mansona
reviewed
Aug 18, 2026
| /** | ||
| Returns a route associated with a bucket | ||
| */ | ||
| getRoute(bucket: Bucket): unknown; |
mansona
reviewed
Aug 18, 2026
| The router passes the in-flight `enterPromise` so the manager can choose | ||
| whether to await data before resolving. | ||
| */ | ||
| getInvokable(bucket: Bucket, enterPromise: Promise<unknown>): Promise<object>; |
…ing is framework's concern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a big PR for a big feature.
Introduces a Route Manager layer between the router and route base classes so the router drives routes through a well-defined manager interface instead of calling classic Route methods directly. This decouples the router from the classic Route and is the stepping stone toward alternative route base classes and a future router. The classic Route behaves exactly as before, there are no changes to app authoring.
Three layers, top to bottom:
@ember/routingpublic re-exports of the authoring API@ember/-internals/routing/route-managersThe classic route manager and route manager infrastructurerouter_jsDrives the routes lifecycle through the manager, and owns the route manager contractWhy does the outlet have a legacy path?
A handful of tests directly set the outlet state, one in particular is testing something for liquid-fire. If there are addons or user code that expects to be able to create their own render state, they will not include the route wrapper and invokable we expect from the route manager, the legacy path path lets them continue working.
Query Params
The current implementation of query params is driven by the router, I have gated the parts that directly reach into routes behind the classic interop capability of route managers. I have left the "machinery" in place in the router. When we come to replace the router, a decision will need to be made if we bridge the classic router manager to use whatever new QP implementation we come up with, or if we fully migrate the router.js QP implementation to be fully encapsulated by the classic route manager.
RFC #1169