Update finding Record section in ember-data guides to teach request service
#2030
+49
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ember-guides ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Baltazore
reviewed
Jun 18, 2024
Baltazore
reviewed
Jan 14, 2025
25 tasks
runspired
reviewed
Feb 21, 2025
runspired
reviewed
Feb 21, 2025
| Use [`store.findRecord()`](https://api.emberjs.com/ember-data/release/classes/Store/methods/findRecord?anchor=findRecord) to retrieve a record by its type and ID. | ||
| This will return a promise that fulfills with the requested record: | ||
| Use [`findRecord()`](https://api.emberjs.com/ember-data/5.3/functions/@ember-data%2Fjson-api%2Frequest/findRecord) to retrieve a record by its type and ID. | ||
| This will return a single `record` or a `array` depends upon the response from server: |
There was a problem hiding this comment.
we should probably introduce builders / the concept of the request first, because this function won't do this on its own and this particular one builds a json:api specific request.
There was a problem hiding this comment.
Umm, that Makes sense. But the builder or the concept of the request will be in a separate document, right? Since this is specific to finding records.
There was a problem hiding this comment.
there's a chicken/egg problem, unsure if its better in a separate file or not because its likely you want to introduce them together
MehulKChaudhari
force-pushed
the
new-emberData/finding-records
branch
from
db66780 to
1ccbdb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make changes to this page
Changes related to ember-data request service paradigm RFC