Skip to content

Add link to Mastodon account #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Add link to Mastodon account #445

merged 2 commits into from
Mar 8, 2023

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Jan 27, 2023

This adds a social media link to our new mastodon account.

It also adds rel="me" to the social media links, which is a semantic hint that these are pages about EmberJS on other sites, and which should cause our Mastodon profile to show as "Verified" as the owner of emberjs.com.

Copy link
Member

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this! 👍

@MelSumner MelSumner requested a review from a team February 17, 2023 20:49
ef4 added 2 commits March 8, 2023 10:49
This adds a social media link to our new mastodon account.

It also adds `rel="me"` to the social media links, which is a semantic hint that these are pages about EmberJS on other sites, and which should cause our Mastodon profile to show as "Verified" as the owner of emberjs.com.
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Some tests with 'continue-on-error: true' have failed:

  • ember-release-no-deprecations

Created by continue-on-error-comment

@mansona mansona merged commit 21942a3 into master Mar 8, 2023
@mansona mansona deleted the add-mastodon branch March 8, 2023 10:58
@jenweber
Copy link
Contributor

Could we backport this commit/PR to a version of ember-styleguide that is compatible with the Guides and API docs?

@jenweber
Copy link
Contributor

Backport PR #463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants