Skip to content

Support ember-try.cjs #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support ember-try.cjs #1089

wants to merge 1 commit into from

Conversation

NullVoxPopuli
Copy link
Contributor

in a type=module project, ember-try.js cannot use require, because js is an ESM

Copy link

codecov bot commented Mar 8, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.19%. Comparing base (7aafbea) to head (c39eded).

Files with missing lines Patch % Lines
lib/utils/config.js 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1089      +/-   ##
==========================================
- Coverage   95.54%   95.19%   -0.36%     
==========================================
  Files          21       21              
  Lines         516      520       +4     
==========================================
+ Hits          493      495       +2     
- Misses         23       25       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kategengler kategengler requested a review from bertdeblock March 9, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant