feat: move ember-cli-build to mjs
#144
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aklkv
force-pushed
the
feat/ember-cli-build
branch
2 times, most recently
from
a7281e3 to
5bd2ccb
Compare
aklkv
commented
Nov 22, 2025
files/ember-cli-build.mjs
Outdated
| @@ -1,13 +1,11 @@ | |||
| 'use strict'; | |||
| import EmberApp from 'ember-cli/lib/broccoli/ember-app'; | |||
Contributor
Author
There was a problem hiding this comment.
this needs to have an extension otherwise build would fail with the error:
Could not `import('file:///Users/aklkv/Projects/work/HashiCorp/cloud-admin/ui/ember-cli-build.mjs')`: Cannot find module '/Users/aklkv/Projects/work/HashiCorp/cloud-admin/ui/node_modules/ember-cli/lib/broccoli/ember-app' imported from /Users/aklkv/Projects/work/HashiCorp/cloud-admin/ui/ember-cli-build.mjs
Did you mean to import "ember-cli/lib/broccoli/ember-app.js"?
should we fix it upstream 🤔
aklkv
force-pushed
the
feat/ember-cli-build
branch
from
5bd2ccb to
46f8843
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #143