Merged
Conversation
|
@chrmod thanks for the PR, would you mind adding test coverage for this change? |
Quick fix to handle path like: `dir1/dir2/file.js`
Member
Author
|
@bcardarella done |
Contributor
|
published |
Merged
Member
|
this was already released so I don't know why it was being picked up in the recent release plan release 🤔 maybe there is a missing tag or something Edit: there was indeed a missing tag in the repo. I fixed that now 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick fix to handle path like:
dir1/dir2/file.jsSorry for not providing tests ATM, have a production bug to fix.
If you need them with this PR can add them in first week of April.