Skip to content

Pass selected options to onChange as first argument #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Pass selected options to onChange as first argument #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59a0998
Add action onChange on component
pankaj-awake Oct 17, 2021
6d1707a
Remove noop usage
pankaj-awake Oct 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addon/components/select-light.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<select
{{on "change" this.change}}
{{on "change" this.onChange}}
...attributes>
{{#if @placeholder}}
<option value="" selected disabled>
Expand Down
21 changes: 17 additions & 4 deletions addon/components/select-light.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
import Component from '@glimmer/component';
import { isNone } from '@ember/utils';
import { isNone, isPresent } from '@ember/utils';
import { action } from '@ember/object';
import { deprecate } from '@ember/debug';

const noop = () => {};

export default class extends Component {
constructor() {
super(...arguments);

this.valueKey = this.args.valueKey ?? 'value';
this.displayKey = this.args.displayKey ?? 'label';
this.change = this.args.onChange ?? this.args.change ?? noop;
this.change = this.args.onChange ?? this.args.change;

deprecate(`Triggering @change on <SelectLight /> is deprecated in favor of @onChange due to ember-template-lint's no-passed-in-event-handlers rule`, !this.args.change, {
id: 'ember-select-light.no-passed-in-event-handlers',
Expand All @@ -28,4 +27,18 @@ export default class extends Component {
this.args.options?.[0][this.displayKey],
].some(isNone);
}

@action
onChange(event) {
if (isPresent(this.change)) {
const { args: { options, valueKey }, change, hasDetailedOptions } = this
let selectedOptions = [...event.target.selectedOptions].map(function(option) {
return hasDetailedOptions ? options.findBy(valueKey, option.value) : option.value
})
if (!event.target.multiple) {
selectedOptions = selectedOptions[0]
}
change(selectedOptions, event)
}
}
}