Additional ArchUnit Tests #1128
Conversation
This commit introduces two additional ArchUnit tests: - com.embabel.agent.core should not depend on com.embabel.agent.api - com.embabel.agent.api should not depend on com.embabel.agent.spi Signed-off-by: Arjen Poutsma <[email protected]>
|
|
||
| @ArchTest | ||
| val apiShouldNotDependOnSpi = | ||
| noClasses().that().resideInAPackage("..api..") |
There was a problem hiding this comment.
Arjen, could you please confirm as per design "api" should not depend on "spi" and what is your envision of relationships.
Perhaps good to have published guidance on relationships (wiki?)
From Web:
The application developer (client) uses classes from the API package.
Internally, the API's implementation code uses a service locator to find available implementations of the SPI interfaces at runtime.
The actual concrete classes that implement the SPI are typically in a separate, implementation-specific package, which the main library dynamically loads.
Therefore, the architectural guideline is to keep the API and SPI packages separate, with the API implementation code using the SPI internally, but the API's interface definitions remaining independent of the specific SPI implementation details.
Thank you.
|
or this just an example of circular dependencies, and can also worded as "no SPI dependencies on API"? |
2 participants
This PR introduces two additional ArchUnit tests: