[fix] lsp-ui not displaying pop-up on MarkedString[]
#784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why?: - There seems to be a typo in extracting the documentation from an array of MarkedString[]. If `lsp-ui-doc-include-signature` is disabled, we still want to display the documentation in the pop-up which should reside in the rest of the MarkedString[] array excluding the first entry. This change addresses the need by: - Turn `cadr` into `cdar` to extract the rest of the first list inside `groups`
|
@jcs090218 could you please take a look and merge it in or provide feedback? |
jcs090218
approved these changes
Dec 4, 2024
|
I think it makes sense. Can you provide screenshots before and after, just for the record? 🤔 Thanks! |
|
@jcs090218 here are the before and after screenshots: before: after: |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?:
lsp-ui-doc-include-signatureis disabled, we still want to display the documentation in the pop-up which should reside in the rest of the MarkedString[] array excluding the first entry.This change addresses the need by:
cadrintocdarto extract the rest of the first list insidegroups