Skip to content

Fix wrong javascript-typescript-langserver in lsp-clients. #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Fix wrong javascript-typescript-langserver in lsp-clients. #509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lsp-clients.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ This directory shoud contain a file matching groovy-language-server-*.jar"
:server-id 'html-ls))

;;; Typescript
(defcustom lsp-clients-typescript-server "typescript-language-server"
(defcustom lsp-clients-typescript-server "javascript-typescript-stdio"
"The typescript-language-server executable to use.
Leave as just the executable name to use the default behavior of
finding the executable with `exec-path'."
Expand All @@ -106,11 +106,10 @@ finding the executable with `exec-path'."
(defun lsp-typescript--ls-command ()
"Generate the language server startup command."
`(,lsp-clients-typescript-server
"--stdio"
,@lsp-clients-typescript-server-args))

(lsp-register-client
(make-lsp-client :new-connection (lsp-stdio-connection '("typescript-language-server" "--stdio"))
(make-lsp-client :new-connection (lsp-stdio-connection (lsp-typescript--ls-command))
:major-modes '(typescript-mode js-mode js2-mode rjsx-mode)
:server-id 'ts-ls))

Expand Down