Add format on save option (issue #3944) #4753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiennq
reviewed
Apr 3, 2025
lsp-mode.el
Outdated
| (defcustom lsp-format-buffer-on-save-list '() | ||
| "If the list is empty format all buffer on save. Else only format buffers | ||
| if their major-mode is in the list." | ||
| :type '(repeat string) |
There was a problem hiding this comment.
I think we should store a list of symbols instead of string. Comparing symbol is always faster than compare string and cost less to store it. Plus, it's more natural to set a list of symbols than a list of string.
There was a problem hiding this comment.
I actually used symbols at first and then changed it to strings cause for some reason though that would be more accessible, but I agree with you using symbols is better.
Updated the branch to use symbols.
Ndot
force-pushed
the
fix-3944-add-format-on-save-option
branch
from
9048e33 to
6b79dd2
Compare
ericdallo
approved these changes
Apr 3, 2025
jcs090218
approved these changes
Apr 3, 2025
jcs090218
approved these changes
Apr 6, 2025
|
Thanks for adding this! |
|
@jcs090218 Thanks. Maybe issue #3944 can be closed? |
ncaq
added a commit
to ncaq/lsp-mode
that referenced
this pull request
Apr 13, 2025
Add `:safe t` and `:local t` properties to `lsp-format-buffer-on-save` to enable project-specific configuration through `.dir-locals.el` without security prompts. Thanks to PR emacs-lsp#4753 for implementing the `format-on-save` functionality. This enhancement allows keeping automatic formatting disabled by default (avoiding unwanted diffs in third-party projects) while enabling it for personal or team projects with established formatting standards. The security implications are minimal since LSP formatting capabilities are limited to code reformatting, and any project where you're running an LSP server already has significant execution privileges.
jcs090218
pushed a commit
that referenced
this pull request
Apr 13, 2025
…4760) Add `:safe t` and `:local t` properties to `lsp-format-buffer-on-save` to enable project-specific configuration through `.dir-locals.el` without security prompts. Thanks to PR #4753 for implementing the `format-on-save` functionality. This enhancement allows keeping automatic formatting disabled by default (avoiding unwanted diffs in third-party projects) while enabling it for personal or team projects with established formatting standards. The security implications are minimal since LSP formatting capabilities are limited to code reformatting, and any project where you're running an LSP server already has significant execution privileges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add format on save (issue #3944) with two option:
lsp-format-buffer-on-saveto turn on / offlsp-format-buffer-on-save-listto specify what major modes to save (nil saves all buffer)