Remove completion with no labels and filterText #4721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyuenho
force-pushed
the
remove-empty-items
branch
from
fae3b97 to
47b512c
Compare
kiennq
reviewed
Mar 2, 2025
kiennq
reviewed
Mar 2, 2025
kiennq
reviewed
Mar 2, 2025
kiennq
reviewed
Mar 2, 2025
kiennq
reviewed
Mar 2, 2025
wyuenho
force-pushed
the
remove-empty-items
branch
from
a0b7b11 to
ef9bfc8
Compare
wyuenho
force-pushed
the
remove-empty-items
branch
from
ef9bfc8 to
5a6c660
Compare
wyuenho
force-pushed
the
remove-empty-items
branch
from
19f4386 to
b29b2d1
Compare
|
@kiennq how does this look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some language servers such as typescript-language-server will occasionally return candidates with an empty string as their labels or filterTexts, this PR filters out these candidates from misbehaving servers, in addition to some slight refactoring to clean up some convoluted logic.