Fix build and add support for both PIO hardware modules #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elmot
reviewed
Jul 27, 2024
| @@ -27,9 +27,9 @@ void set_value_and_log(uint channel, uint value_usec) { | |||
|
|
|||
| } | |||
| int main() { | |||
| setup_default_uart(); | |||
| uint pin = 3; | |||
There was a problem hiding this comment.
The file header still notes pin 3 and PIO0, and that should be in sync with the code
Probably it's better to add some macro or a piece of validation code to be sure that PIO, GPIO, and IRQ are in sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was running into issues with the wrong definition of
PIO_INTR_SM0_TXNFULL_LSBbeing used. That was fixed by replacing it withpis_sm0_tx_fifo_not_full.Also added the ability to use both
pio0andpio1hardware.