Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fantomas tool and format F# code #573

Closed
wants to merge 3 commits into from

Conversation

LyndonGingerich
Copy link
Contributor

Resolves #434

Should I examine any particular settings to minimize changes?

@LyndonGingerich
Copy link
Contributor Author

Do we want a build tool to ensure that merged code is formatted correctly?

@TysonMN
Copy link
Member

TysonMN commented Jul 6, 2023

Do we want a build tool to ensure that merged code is formatted correctly?

I think that would be good.

Are the formatting choices of Fantomas configurable?

@LyndonGingerich
Copy link
Contributor Author

Are the formatting choices of Fantomas configurable?

Very. https://fsprojects.github.io/fantomas/docs/end-users/Configuration.html

@rfreytag
Copy link
Contributor

Had not seen Fantomas before. So, I looked at Fantomas looking for some standardization of blank line practices like skipping extra, extra lines after Modules and could not find that. Did I miss it? Since you folks like that practice you might want to customize your usage of Fantomas to include that practice.

@LyndonGingerich
Copy link
Contributor Author

@rfreytag I don't think that Fantomas removes newlines except at the ends of files.

@LyndonGingerich
Copy link
Contributor Author

LyndonGingerich commented Jul 12, 2023

@TysonMN Should I look into a GitHub action? It would take a while, and I don't (and probably shouldn't) have the access required to create one here.

@LyndonGingerich
Copy link
Contributor Author

LyndonGingerich commented Jul 12, 2023

@rfreytag There is a setting for the maximum number of consecutive blank lines, but it doesn't distinguish between blank lines after modules and blank lines elsewhere.

Since you folks like that practice

What are you referencing? Was there a particular issue involving blank lines?

@LyndonGingerich LyndonGingerich requested a review from TysonMN August 1, 2023 20:50
@marner2
Copy link
Collaborator

marner2 commented Aug 23, 2023

This is probably a good idea and should be merged in.

@LyndonGingerich you can modify the github actions yourself by editing the files in .github/workflows/pull_request.yml|continuous_integration.yml

@LyndonGingerich
Copy link
Contributor Author

I've let this branch grow old. I'll make another rather than dealing with merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fantomas code formatter
4 participants