Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#157 one way seq via one way seq lazy #258

Merged
merged 9 commits into from
Aug 11, 2020

Conversation

TysonMN
Copy link
Member

@TysonMN TysonMN commented Aug 11, 2020

This PR implements the oneWaySeq binding method via the oneWaySeqLazy method with equals = refEq and map = id.

I described more about this branch in #253 (comment).

The only documentation I changed was in the ///-style documentation above the relevant binding method.

@cmeeren
Copy link
Member

cmeeren commented Aug 11, 2020

Could you add a note about the behavior change to the changelog?

@TysonMN TysonMN mentioned this pull request Aug 11, 2020
9 tasks
@TysonMN
Copy link
Member Author

TysonMN commented Aug 11, 2020

Could you add a note about the behavior change to the changelog?

Done. How is that?

@TysonMN TysonMN force-pushed the #157_OneWaySeq_via_OneWaySeqLazy branch from c38a205 to 5b65a5e Compare August 11, 2020 19:32
@cmeeren
Copy link
Member

cmeeren commented Aug 11, 2020

Looks good, merge when you're ready. 👍

@TysonMN TysonMN merged commit acc1f1b into elmish:v4 Aug 11, 2020
@TysonMN TysonMN deleted the #157_OneWaySeq_via_OneWaySeqLazy branch August 11, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants