-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove wrapDispatch and add mapMsgWithModel #256
Conversation
This comment has been minimized.
This comment has been minimized.
Is there anything outstanding here? Anything I should review that I haven't already? |
Come to think of it, IMHO the PRs should include relevant documentation/README updates, such as changelog items, migration steps, and relevant changes to the tutorial. |
27a1294
to
431bcb4
Compare
I updated the release notes. What other documentation changes would you like ot see? |
Please remove the "Wrapping dispatch" section of the tutorial. I'd also like the tutorial to explain and demonstrate the new functions. Where/when are they useful, how to use them correctly, any gotchas to watch out for if applicable, etc. In short, the simplest possible explanation (but no simpler) that will make users who have no idea they need these functions understand how great they are and how/when they can use them and how it improves their code. :) |
9ccead0
to
5e7c11a
Compare
I updated the tutorial. How does that look? |
Another thing to review is all the types I exposed in this commit. Should I add |
Looks good! Could you also add something about how it enables you to factor out XAML controls? That's a (perhaps the?) major benefit, as I understand it.
Could you make the implementations internal? Actually, why are they public in the first place? |
f82cd6e
to
6cf0b52
Compare
The XAML can already be extracted. For the I will add something about this to the tutorial.
Ah, yes! You are right. Thanks for pushing back on this. I wasn't being very precise when I did that commit. Conceptually what I wanted was to publicly expose the six mapping functions (three in Instead, I just rebased into my branch this commit that publicly exposes the six mapping functions but keeps everything else internal. So I will add |
As you have noticed (but repeating here for the record), I have added to the tutorial about the design-time benefit that comes from the mapping functions and added |
Looks good to me. Feel free to merge! |
ad8e85b
to
f459057
Compare
Great! :D I squashed some commits. I will complete after the automated build finishes successfully. |
This PR is a merge into the new branch
v4
. It replaces the draft PR #244.@cmeeren, there are conflicts between this branch and your logging branch. Do you mind if we review and complete this PR first and then you resolve the conflicts with your logging branch?