SubModelSeq update logic now more functional #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TysonMN
force-pushed
the
improve_SubModelSeq_update
branch
from
3ff5994 to
5fdbdc9
Compare
TysonMN
force-pushed
the
improve_SubModelSeq_update
branch
from
5fdbdc9 to
1ea4d1f
Compare
cmeeren
requested changes
Jul 22, 2020
TysonMN
force-pushed
the
improve_SubModelSeq_update
branch
2 times, most recently
from
47274b0 to
0c05717
Compare
cmeeren
requested changes
Jul 23, 2020
TysonMN
force-pushed
the
improve_SubModelSeq_update
branch
2 times, most recently
from
04c74fb to
b1bc3a2
Compare
cmeeren
requested changes
Jul 25, 2020
cmeeren
approved these changes
Jul 25, 2020
|
I'm happy with this. Feel free to merge. Thanks for your work! |
TysonMN
force-pushed
the
improve_SubModelSeq_update
branch
from
f2e76a8 to
41e2207
Compare
|
I locally squashed and rebased onto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only changes code in the
SubModelSeqsample.At a high level, the changes are to use more higher-order functions in order to be both more succinct and have more reusable code.
My intention is for the behavior to be unchanged. I also expect the performance to be the same. These changes are not trying to address #236.
I tested this, and I think everything still works the same.
@ScottHutchinson, I think you will be interested in these changes since you are using a
SubModelSeqbinding.