-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dockerfile #3428
base: main
Are you sure you want to change the base?
Update Dockerfile #3428
Conversation
This no longer runs properly with the --no-frozen-lockfile command set
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kyle-veniceai! Welcome to the elizaOS community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now an elizaOS contributor!
This no longer runs properly with the --no-frozen-lockfile command set
Relates to
Risks
Low: The lockfile is no longer set, but is now inhereted
Background
Docker build fails because of --no-frozen-lockfile attached to RUN pnpm install --no-frozen-lockfile
What does this PR do?
With the deprecation of the --no-frozen-lockfile, this needs to be removed from the Dockerfile to build properly
What kind of change is this?
Minor change for pnpm install to run correctly in the docker build
Bug fix
Dockerfile build fails
=> ERROR [builder 6/7] RUN pnpm install --no-frozen-lockfile
ERROR: failed to solve: process "/bin/sh -c pnpm install --no-frozen-lockfile" did not complete successfully: exit code: 1
Documentation changes needed?
No change required
Local build runs properly with change
Testing
Where should a reviewer start?
Run docker build on current github repo to see failure. Run docker build with update to see successful build.
Detailed testing steps
=> ERROR [builder 6/7] RUN pnpm install --no-frozen-lockfile
ERROR: failed to solve: process "/bin/sh -c pnpm install --no-frozen-lockfile" did not complete successfully: exit code: 1