fix: handle invalid json #3258
fix: handle invalid json #3258
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| const attributes: { [key: string]: string | undefined } = {}; | ||
|
|
||
| if (!attributesToExtract || attributesToExtract.length === 0) { | ||
| // Extract all attributes if no specific attributes are provided | ||
| const matches = response.matchAll(/"([^"]+)"\s*:\s*"([^"]*)"/g); | ||
| const matches = response.matchAll(/"([^"]+)"\s*:\s*"([^"]*)"?/g); |
There was a problem hiding this comment.
Making the closing quote optional with "? could allow the regex to match incomplete JSON values. For example, "name": "John would match, even though it's missing the closing quote. This creates a risk of silently accepting malformed data. Consider keeping the strict quote requirement and adding explicit error handling to provide better feedback when the JSON is invalid.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
tcm390
force-pushed
the
tcm-handle-invalid-json
branch
from
e1d9fba to
eb15c6e
Compare
related: #3245