Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Google vertex provider support (CONFLICTED) #3136

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

yohairosen
Copy link

Relates to

N/A

Risks

Medium. Potential integration issues with Google Vertex AI authentication and API limits.

Background

What does this PR do?

Adds Google Vertex AI support as a model inference provider.

What kind of change is this?

Features (non-breaking change which adds functionality)

Why are we doing this? Any context or related work?

It adds ability to use models deployed on Google Vertex

Documentation changes needed?

My changes require a change to the project documentation to include setup and configuration details for Google Vertex AI integration.

Testing

Where should a reviewer start?

  1. Review the updated code for Google Vertex AI integration.
  2. Verify that the correct environment variables are set in the .env file.
  3. Check for any potential API authentication or quota issues.
  4. Test embedding model
  5. Try different models on Vertex, hugging face, and Claude for example, tested only on Gemani

Detailed testing steps

  1. Set up Google Vertex AI in your Google Cloud project.

    • Ensure the Vertex AI API is enabled.
    • Configure service account credentials.
  2. Add the required Google Vertex AI environment variables in your .env file (refer to .env.example):

    ####################################
    #### Google Vertex Provider ####
    ####################################
    GOOGLE_VERTEX_KEY=                  # "-----BEGIN PRIVATE KEY-----\n YOUR_PRIVATE \n-----END PRIVATE KEY-----\n"
    GOOGLE_VERTEX_EMAIL=                # [email protected]
    GOOGLE_VERTEX_LOCATION=             # us-central1
    GOOGLE_VERTEX_PROJECT=              # project-plexus-447108-e4
    SMALL_GOOGLE_VERTEX_MODEL=          # gemini-2.0-flash-exp
    MEDIUM_GOOGLE_VERTEX_MODEL=         # gemini-2.0-flash-exp
    LARGE_GOOGLE_VERTEX_MODEL=          # gemini-1.5-pro-002
    GOOGLE_VERTEX_EMBEDDING_MODEL=
    • You can obtain the values for GOOGLE_VERTEX_KEY, GOOGLE_VERTEX_EMAIL, GOOGLE_VERTEX_LOCATION, and GOOGLE_VERTEX_PROJECT from the Google Cloud service account JSON file that you download when setting up your credentials.
  3. Update a character file and add:

    "modelProvider": "google_vertex_api",
  4. Run:

    pnpm install && pnpm build
    pnpm run start --characters="./characters/<file name>"
  5. In another terminal, start the client:

    pnpm start:client
  6. Access localhost:5173 and request an image generation from your agent.

Discord username

luenai

Copy link
Contributor

coderabbitai bot commented Feb 1, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@odilitime odilitime changed the title feat: Add Google vertex provider support feat: Add Google vertex provider support (CONFLICTED) Feb 19, 2025
@lalalune lalalune enabled auto-merge February 21, 2025 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants