Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check whether REMOTE_CHARACTER_URLS env is defined in starting agent #2382

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

dev-whoan
Copy link
Contributor

@dev-whoan dev-whoan commented Jan 16, 2025

Relates to

  • Without this condition it will return Unhandled error in startAgents when REMOTE_CHARACTER_URLS is not defined in environment variable

Risks

large

  • Agent will not be started.

Background

What does this PR do?

  • Fix hasValidRemoteUrls so the agent can be operated.

What kind of change is this?

  • Bug fix.
    • To operate agent without REMOTE_CHARACTER_URLS env var, and the function name
      • hasValidRemoteUrls, it should check whether the env has set or not.
      • Without this PR, it will return following error when the env is not set.
      ⛔ ERRORS
      [eliza] Unhandled error in startAgents: 
      {} 
      

Documentation changes needed?

  • No.

Testing

  • No test. just easy fix.

Where should a reviewer start?

  • Only 1 file changed, eliza/agent/index.ts -> hasValidRemoteUrls

Detailed testing steps

Discord username

@ Patata

@dev-whoan dev-whoan changed the title fix: check env REMOTE_CHARACTER_URLS is defined fix: check whether REMOTE_CHARACTER_URLS env is defined in starting agent Jan 16, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dev-whoan! Welcome to the elizaOS community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now an elizaOS contributor!

@wtfsayo
Copy link
Member

wtfsayo commented Jan 16, 2025

thanks got this covered in #2384 pretty close

@wtfsayo wtfsayo closed this Jan 16, 2025
@wtfsayo wtfsayo reopened this Jan 16, 2025
@wtfsayo wtfsayo enabled auto-merge (squash) January 16, 2025 13:50
@wtfsayo wtfsayo self-requested a review January 16, 2025 14:17
Copy link
Member

@wtfsayo wtfsayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doing empty merge for contribution credits

@wtfsayo wtfsayo merged commit 63e4dbd into elizaOS:develop Jan 16, 2025
3 checks passed
@dev-whoan
Copy link
Contributor Author

dev-whoan commented Jan 16, 2025

@wtfsayo lmao thanks.

can I get contributor role on Discord? @ Patata

@wtfsayo
Copy link
Member

wtfsayo commented Jan 16, 2025

I dont have access also too early!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants