Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken code example in Protobuf.TransformModule docs #383

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Fix broken code example in Protobuf.TransformModule docs #383

merged 1 commit into from
Dec 3, 2024

Conversation

v0idpwn
Copy link
Collaborator

@v0idpwn v0idpwn commented Dec 3, 2024

Noticed while opening #382.

Per 0.13.0, calling defstruct (without @type) raises a compile error (see

protobuf/test/protobuf/dsl_test.exs

Line 280 in 0f5e070

test "raises a compilation error if there is already a call to defstruct/1 but no definition for the t/0 type" do
)

@v0idpwn v0idpwn merged commit 27c5716 into main Dec 3, 2024
3 checks passed
@v0idpwn v0idpwn deleted the fix/broken-example-in-docs branch December 3, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@v0idpwn