Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for Elixir 1.17/OTP 27 #372

Merged
merged 8 commits into from
Jun 17, 2024

Conversation

v0idpwn
Copy link
Collaborator

@v0idpwn v0idpwn commented May 20, 2024

Also makes lint, integration and coverage run on Elixir 1.15, OTP 26.

OTP 27 was released today.

v0idpwn added 2 commits May 20, 2024 18:50
Also makes lint, integration and coverage run on Elixir 1.15, OTP 26
Changes in ordering make the generated files look different, causing
a CI error.
@whatyouhide
Copy link
Collaborator

Mh still fails to fetch the new OTP in CI. Also, while we fix that: let's not add OTP 25. Ideally we only need to test on newest and oldest supported versions.

@ericmj
Copy link
Collaborator

ericmj commented May 21, 2024

There are no Elixir versions that are compatible with OTP 27 yet.

https://hexdocs.pm/elixir/main/compatibility-and-deprecations.html#between-elixir-and-erlang-otp

@v0idpwn v0idpwn changed the title Add CI for Elixir 1.16/OTP 27 and 1.15/OTP 26 Add CI for Elixir 1.17/OTP 27 and 1.15/OTP 26 Jun 17, 2024
@v0idpwn
Copy link
Collaborator Author

v0idpwn commented Jun 17, 2024

Thanks, @ericmj, and sorry for the noise. I didn't realize we needed official support, as I had tried elixir 1.16 and OTP 27 with success.

Updated to use Elixir 1.17 since it was released.

@v0idpwn
Copy link
Collaborator Author

v0idpwn commented Jun 17, 2024

Hm, I wanted to bump stream_data to avoid a deprecation warning but would need to drop support for older erlang/elixir (it seems that pre-otp 24 and pre-elixir 1.12.3 are problems). Would you be interested in dropping support for these versions or should I just accept the warnings and keep using an older stream_data version?

@v0idpwn
Copy link
Collaborator Author

v0idpwn commented Jun 17, 2024

Also,

Also, while we fix that: let's not add OTP 25. Ideally we only need to test on newest and oldest supported versions.

So I should test only for OTP 27 and 23.3? What about Elixir versions?

@whatyouhide
Copy link
Collaborator

@v0idpwn yes, only OTP 27/Elixir 1.17 + OTP 23/erliest Elixir version (can't remember which one it is, maybe we go with 1.10).

@v0idpwn
Copy link
Collaborator Author

v0idpwn commented Jun 17, 2024

Done. I couldn't change conformance tests version as it would cause errors. I can maybe address this in another PR.

The most important thing on this one is that we test with OTP 27 due to the OTP27+ specific code added on #370.

@v0idpwn v0idpwn changed the title Add CI for Elixir 1.17/OTP 27 and 1.15/OTP 26 Add CI for Elixir 1.17/OTP 27 Jun 17, 2024
@whatyouhide whatyouhide merged commit e0920e3 into elixir-protobuf:main Jun 17, 2024
3 checks passed
@whatyouhide
Copy link
Collaborator

Fantastic, thanks @v0idpwn ❤️

@v0idpwn v0idpwn deleted the ci/otp-27-and-bumps branch June 17, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants