Don't encode a struct as another struct #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am guessing there are people that rely on this behavior, at least accidentally, so I think we need to ship as a breaking change. |
ericmj
approved these changes
May 15, 2024
|
Yeah it's a breaking change but honestly a very good one 😄 We'll have to revamp a bunch of stuff and I'd love to get to a 1.0, so I don't think this is a big issue. |
whatyouhide
reviewed
May 15, 2024
|
I will go ahead and merge this. We can always start a new branch if we need to do more minor/patch releases before bumping major. |
|
Thank you @v0idpwn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #365
This is a breaking change, as you could rely on the automatic transformation between structs. I don't think that should be done, though.