Add lib/elixirpb to package files #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmj
reviewed
Feb 10, 2024
mix.exs
Outdated
| @@ -76,6 +76,7 @@ defmodule Protobuf.Mixfile do | |||
| files: ~w( | |||
| mix.exs | |||
| README.md | |||
| lib/elixirpb | |||
There was a problem hiding this comment.
I think we can remove the :files config all together. It already seems to include what hex includes by default https://github.com/hexpm/hex/blob/main/lib/hex/package.ex#L4.
There was a problem hiding this comment.
@ericmj Thanks, that sounds reasonable. I've updated my patch to remove the :files config entirely.
ericmj
approved these changes
Feb 14, 2024
|
Hope this gets fixed and released soon .. |
|
Thanks @sekiyama58 💟 |
sekiyama58
added a commit
to aktsk/protoc-gen-validate
that referenced
this pull request
Jun 4, 2024
The issue is fixed by elixir-protobuf/protobuf#368. Until this is released as a new version, use the trunk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue that
option (elixirpb.file).module_prefixis not loaded correctly if the protobuf package is installed from Hex, due to missing lib/elixirpb/pb_extension.pb.ex in the 0.11.0 or 0.12.0 packages.Closes #367