-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manifold learning notebooks #278
Manifold learning notebooks #278
Conversation
@krstopro do you know there is any way to add support in LargeVis or precisely in RPF for data that is in test cases here and currently fails? |
@msluszniak Yeah, I should fix that. The main reason I didn't do it in the first place was because I wouldn't recommend using random projection forest for those cases, i.e. when the sample size is less than two times leaf size. I would recommend making k-NN algorithm configurable for Trimap. Similarly as it was done in |
Yeah, that's a good idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, few comments on the writing from my side.
Co-authored-by: Krsto Proroković <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it once CI passes!
I decided to replace NNDescent in Trimap with LargeVis. In the original implementation of Trimap, authors used Annoy, which is more similar to LargeVis and it's faster. In Google's implementation using Jax, they use NNDescent, which is slower and eventually makes the whole implementation slower than the not-optimised, original one.
original implementation: https://github.com/eamid/trimap
Google implementation: https://github.com/google-research/google-research/tree/master/trimap