Add gen_server timeout example
#14530
Open
+35
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
approved these changes
May 25, 2025
sabiwara
approved these changes
May 25, 2025
| end | ||
|
|
||
| A `Counter` server will exit with `:normal` if there are no messages in 5 seconds | ||
| after the initialization or after the last `succ` call: |
There was a problem hiding this comment.
I didn't understand what succ stands for, how about naming this :incr since this is a counter?
There was a problem hiding this comment.
https://en.wikipedia.org/wiki/Successor_function
I thought succ better explains what is going on, initial thought was to useincr :-)
Should we change it?
There was a problem hiding this comment.
I would suggest to not use abbreviations in documentation. It's clearer to use :success or :increment instead.
Co-authored-by: Jean Klingler <[email protected]>
| end | ||
|
|
||
| A `Counter` server will exit with `:normal` if there are no messages in 5 seconds | ||
| after the initialization or after the last `succ` call: |
There was a problem hiding this comment.
I would suggest to not use abbreviations in documentation. It's clearer to use :success or :increment instead.
| end | ||
|
|
||
| A `Counter` server will exit with `:normal` if there are no messages in 5 seconds | ||
| after the initialization or after the last `succ` call: |
There was a problem hiding this comment.
Suggested change
| after the initialization or after the last `succ` call: | |
| after the initialization or after the last `:succ` call: |
| GenServer.call(counter_pid, :succ) | ||
| #=> 51 | ||
|
|
||
| # After 5 secs |
There was a problem hiding this comment.
Suggested change
| # After 5 secs | |
| # After 5 seconds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.