Print intermediate results of dbg for boolean operators#14217
Merged
sabiwara merged 1 commit intoelixir-lang:mainfrom Jan 23, 2025
Merged
Print intermediate results of dbg for boolean operators#14217sabiwara merged 1 commit intoelixir-lang:mainfrom
sabiwara merged 1 commit intoelixir-lang:mainfrom
Conversation
josevalim
approved these changes
Jan 23, 2025
Contributor
Author
|
@josevalim for code blocks, I think we could do it if we simplify it a bit (no loss IMHO): (a=1; b=2; a + b) |> dbg()Current: Code block:
(
a = 1 #=> 1
b = 2 #=> 2
a + b #=> 3
)Instead I propose: a = 1 #=> 1
b = 2 #=> 2
a + b #=> 3WDYT? |
Member
|
Agreed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking 40164fc one step further and support and/or boolean operators, leveraging the new list of nodes approach:
Basically we'll generate these:
I think
__block__would make sense too and could be done in a same way.