Skip to content

Encode protobuf to iodata for better performance #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2025

Conversation

v0idpwn
Copy link
Contributor

@v0idpwn v0idpwn commented Dec 28, 2024

No description provided.

@v0idpwn
Copy link
Contributor Author

v0idpwn commented Dec 28, 2024

We can do the same for JSON once elixir-protobuf/protobuf#388 is released.

@sleipnir
Copy link
Collaborator

@polvalente I think it's time for us to move on with this. Wdyt?

@polvalente
Copy link
Contributor

@polvalente I think it's time for us to move on with this. Wdyt?

We gotta bump to 0.10 upon merging this (which we can already).

In that case, I think we could also start using Keyword.validate! throughout the lib and drop support from Elixir 1.12 in the process.

@sleipnir
Copy link
Collaborator

@polvalente I think it's time for us to move on with this. Wdyt?

We gotta bump to 0.10 upon merging this (which we can already).

In that case, I think we could also start using Keyword.validate! throughout the lib and drop support from Elixir 1.12 in the process.

I agree

@polvalente polvalente merged commit 862697b into elixir-grpc:master Apr 27, 2025
19 of 24 checks passed
@v0idpwn v0idpwn deleted the protobuf-perf branch April 27, 2025 14:31
@v0idpwn
Copy link
Contributor Author

v0idpwn commented Apr 27, 2025

If you're interested, I can send a PR for JSON as well, but it would require bumping protobuf to 0.14

@sleipnir
Copy link
Collaborator

If you're interested, I can send a PR for JSON as well, but it would require bumping protobuf to 0.14

Of course it would be very welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants