-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
embed dll loader #120
embed dll loader #120
Conversation
Signed-off-by: Cocoa <[email protected]>
Signed-off-by: Cocoa <[email protected]>
Signed-off-by: Cocoa <[email protected]>
Amazing @cocoa-xu! Agreed with the fix :) |
Although the error message from Windows was @DnOberon I shipped v0.7.4 which now embeds the dll loader for Windows. Please let me know if that works for you. And if not, could you please also include some steps for me to reproduce? |
Sound excellent @cocoa-xu, will do |
Alright @cocoa-xu the plot thickens - what information do you need from me to reproduce? Windows 10 - added Visual Studio Code Build Tools 2022 and the C++ build section. Running the Developer Powershell. Fresh project using the latest adbc . Seems like the files compiled or downloaded successfully though? |
@DnOberon Okay, v0.7.5 should work now :) |
Hmm the error doesn't seem as big - but still getting one |
Hi @DnOberon could you please share the commands you were using that can lead to this result? |
That same error appears on a simple ‘mix deps.compile’ after cloning the fresh project
|
Sorry but I couldn't reproduce the same error... It would be really helpful if you could provide more detailed commands that you were using
|
Will do. Give me a bit and I'll make a fresh project and turn debug on :) |
is this helpful? Happens both in existing and fresh project with ADBC as the only dependency. If I copy the release in manually from the release on Github, it works. So I'm assuming it's something up with my compiling going wrong. Edit: Oh and I'm using the DuckDB driver |
Yes, I can reproduce the failure on macOS too. Maybe we should release those versions as release candidates, so we don't break existing workflows? For example, Livebook relies on ADBC for some work and it will fetch the latest version by default. :) |
I did it separately @cocoa-xu so you could more easily see the error. The same error appears on mix compile or mix release |
It works on macOS again, thanks @cocoa-xu :) |
Correct |
Alright then let me recompile and run on windows on the latest and see if it happens at runtime too. Thanks |
I really need to setup a dev hex.pm repo for testing.. |
@cocoa-xu you can use https://github.com/elixir-lang/ex_doc/blob/main/test/prerelease.sh Maybe we could have a similar script here? |
Oh this sounds like a good fit here, I'll look into this later today! |
Related issue: cocoa-xu/dll_loader_helper_beam#4
/cc @DnOberon