-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP fix CI #180
base: dev
Are you sure you want to change the base?
WIP fix CI #180
Conversation
Reviewer's Guide by SourceryThis pull request fixes typos and broken links in the README file. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Saw couple of minor issues while writting readme for proWES. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JaeAeich - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
CI fails :) Just changed the readme!! We def should update deps of these repositories don't we. |
@uniqueg I give up, given this PR was meant for readme, all those fixes have already spiralled out of control. Maybe we fix that in a separate PR then care about some broken links in |
I think this PR could still be useful for someone else. Just instead of the README changes, it could focus on the linting issues. |
Summary by Sourcery
Documentation: