Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP fix CI #180

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

WIP fix CI #180

wants to merge 5 commits into from

Conversation

JaeAeich
Copy link
Contributor

@JaeAeich JaeAeich commented Dec 19, 2024

Summary by Sourcery

Documentation:

  • Fix typos and broken links in the README file.

@JaeAeich JaeAeich requested a review from uniqueg December 19, 2024 14:53
Copy link

sourcery-ai bot commented Dec 19, 2024

Reviewer's Guide by Sourcery

This pull request fixes typos and broken links in the README file.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Fixed typos and grammatical errors.
  • Corrected the spelling of "subdiretories" to "subdirectories".
  • Corrected the grammar in the sentence describing the purpose of proTES gateway.
  • Corrected the spacing in the "Bringing compute to the data" section.
README.md
Updated broken links.
  • Replaced the broken link for semantic versioning with the correct link.
  • Removed the broken link to the GA4GH TES OpenAPI specification.
  • Removed several unused links, including links to Connexion, GA4GH Cloud, and MongoDB.
README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@JaeAeich
Copy link
Contributor Author

Saw couple of minor issues while writting readme for proWES.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JaeAeich - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@JaeAeich
Copy link
Contributor Author

JaeAeich commented Dec 19, 2024

CI fails :)

Just changed the readme!!

We def should update deps of these repositories don't we.

@JaeAeich
Copy link
Contributor Author

@uniqueg I give up, given this PR was meant for readme, all those fixes have already spiralled out of control. Maybe we fix that in a separate PR then care about some broken links in readme.md :).

@uniqueg
Copy link
Member

uniqueg commented Jan 9, 2025

I think this PR could still be useful for someone else. Just instead of the README changes, it could focus on the linting issues.

@uniqueg uniqueg reopened this Jan 9, 2025
@uniqueg uniqueg removed their request for review January 9, 2025 02:07
@uniqueg uniqueg marked this pull request as draft January 9, 2025 02:07
@uniqueg uniqueg changed the title chore: readme fix WIP fix CI Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants