-
Notifications
You must be signed in to change notification settings - Fork 2
docs(admin): describe LS Login configuration #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR adds documentation for integrating LS-AAI (Life Science Login) authentication into different services. The implementation consists of adding a new markdown file with detailed configuration guides for JupyterHub and Hedgedoc services, along with updating the mkdocs navigation to include the new guide. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @svedziok - I've reviewed your changes - here's some feedback:
Overall Comments:
- The file path in mkdocs.yml (guide-admin/services_to_ls_aai.md) doesn't match the actual file location (guide-dev/services_to_ls_aai.md). Please ensure these paths are consistent.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 3 issues found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! Some minor comments. And I think the comments from Sourcery are also good
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Add admin guide on how to integrate LS-AAI in different services.
Summary by Sourcery
Documentation: