Update Helm Chart #260
Open
Update Helm Chart #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update mongodb image - Add init-script js - Add condition if storage is RWO and not RWX - Pods will run on the same node - Update RabbitMQ image
Reviewer's GuideThis PR overhauls the Helm chart by refactoring values and defaults, introducing resource configurations across all containers, restructuring MongoDB secret handling and initialization, adding node‐affinity for RWO storage, bumping chart metadata, and aligning documentation with the new parameters. Entity relationship diagram for updated MongoDB secret and init scripterDiagram
MONGODB_SECRET {
string databaseRootUsername
string databaseRootPassword
string databaseUser
string databasePassword
string databaseName
}
MONGODB_INIT_SCRIPT {
string init_script_js
}
MONGODB ||--|| MONGODB_SECRET : uses
MONGODB ||--|| MONGODB_INIT_SCRIPT : uses
WES ||--|| MONGODB_SECRET : uses
CELERY_WORKER ||--|| MONGODB_SECRET : uses
Class diagram for updated Helm chart values structureclassDiagram
class Values {
string applicationDomain
string clusterType
string tlsSecret
string storageAccessMode
ExtraConfig extra_config
Autocert autocert
Flower flower
Wes wes
CeleryWorker celeryWorker
MongoDB mongodb
RabbitMQ rabbitmq
Ingress ingress
}
class ExtraConfig {
string folder
string file
}
class Autocert {
string createJob
string schedule
string testCert
string image
}
class Flower {
string appName
string image
}
class Wes {
string appName
string image
Resources initResources
Resources resources
string storageClass
string volumeSize
boolean redirect
boolean configWithJob
string appConfig
}
class CeleryWorker {
string appName
string image
Resources initResources
Resources resources
string tmpVolumeSize
boolean tmpCleaner
}
class MongoDB {
string appName
Secret secret
string volumeSize
string image
Resources resources
string mountPath
string pullPolicy
SecurityContext securityContext
}
class Secret {
string databaseRootUsername
string databaseRootPassword
string databaseUser
string databasePassword
string databaseName
}
class Resources {
Limits limits
Requests requests
}
class Limits {
string cpu
string memory
}
class Requests {
string cpu
string memory
}
class SecurityContext {
boolean enabled
boolean runAsNonRoot
int runAsUser
}
class RabbitMQ {
string appName
string volumeSize
string image
Resources resources
}
class Ingress {
string letsencryptSystem
}
Values --> ExtraConfig
Values --> Autocert
Values --> Flower
Values --> Wes
Values --> CeleryWorker
Values --> MongoDB
Values --> RabbitMQ
Values --> Ingress
Wes --> Resources
Wes --> Resources : initResources
CeleryWorker --> Resources
CeleryWorker --> Resources : initResources
MongoDB --> Secret
MongoDB --> Resources
MongoDB --> SecurityContext
RabbitMQ --> Resources
Flow diagram for node affinity when storage is RWOflowchart TD
A["storageAccessMode = ReadWriteOnce"] --> B["Apply podAffinity"]
B --> C["WES and Celery Worker scheduled on same node"]
D["storageAccessMode = ReadWriteMany"] --> E["No podAffinity"]
E --> F["Pods can be scheduled on different nodes"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `deployment/README.md:106` </location>
<code_context>
| autocert.schedule | string | schedule for certificate refreshment |
| autocert.testCert | string | whether to use Let's Encrypt staging so as not to exceed quota |
+| flower.appName | string | Name for the flower app |
+| flower.basicAuth | string | Set the username and password for the Flowe app |
+| flower.image | string | Container image to be used for Flower |
+| wes.appName | string | name of the main application on Kubernetes cluster |
</code_context>
<issue_to_address>
**issue (typo):** Typo: 'Flowe app' should be 'Flower app'.
Update the description to use 'Flower app' instead of 'Flowe app'.
```suggestion
| flower.basicAuth | string | Set the username and password for the Flower app |
```
</issue_to_address>
### Comment 2
<location> `deployment/README.md:109` </location>
<code_context>
+| flower.basicAuth | string | Set the username and password for the Flowe app |
+| flower.image | string | Container image to be used for Flower |
+| wes.appName | string | name of the main application on Kubernetes cluster |
+| wes.image | string | containger image to be used for the main application |
+| wes.initResources | string | Set limits and requests cpu/memory for the WES initContainer (busybox) |
+| wes.resources | string | Set limits and requests cpu/memory for the WES container |
</code_context>
<issue_to_address>
**issue (typo):** Typo: 'containger' should be 'container'.
Update the description to use the correct spelling: 'container'.
```suggestion
| wes.image | string | container image to be used for the main application |
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please create an issue before filing a pull request! Changes need to be discussed before proceeding. Please read the contribution guidelines.
Details
Please provide enough information so that others can review your pull request. Give a brief summary of the motivation. Refer to the corresponding issue/s with
#XXXXfor more information.Testing
Write the appropriate unit and integration tests, if applicable. Make sure these and all other tests pass.
Documentation
Please document your changes and test cases in the appropriate places, if applicable.
Style
Make sure your changes adhere to the coding/documentation style used throughout the project.
Closing issues
If your changes fix any issue/s, put
closes #XXXXin your comment to auto-close it/them.Credit
Add your credentials to the list of contributors once your pull request was merged.
Summary by Sourcery
Enhance the Helm chart by renaming it to drs-filer, bumping to version 2.0.0, and adding configurable resource parameters, storage conditions, and initialization scripts for MongoDB.
Enhancements:
Deployment:
Documentation: