-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: source asdf
and initialize direnv
#71
Conversation
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Nidhi091999 - I've reviewed your changes - here's some feedback:
Overall Comments:
- The pull request appears to be missing the actual code changes. Please ensure all intended modifications are included in the commit.
- Please provide more context in the PR description about what issue fix: source direnv and extension in dev container #65 entails and how these changes resolve it.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@Nidhi091999 This is a small change. please re create the PR with signed commits, I have bypassed and merged your previous PR, but lets now have signed commit. |
@JaeAeich As shown in the screenshot, my commits are signed. If there's anything I might have overlooked, please let me know so I can address it accordingly. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
asdf
and initialize direnv
@Nidhi091999: Thanks a lot for this! Feel free to go ahead and merge, given that the PR is approved :) |
resolves #65
Summary by Sourcery
CI: