Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: source asdf and initialize direnv #71

Merged
merged 2 commits into from
Mar 10, 2025
Merged

fix: source asdf and initialize direnv #71

merged 2 commits into from
Mar 10, 2025

Conversation

Nidhi091999
Copy link
Contributor

@Nidhi091999 Nidhi091999 commented Jan 30, 2025

resolves #65

Summary by Sourcery

CI:

  • Initialize asdf and direnv in the devcontainer's override.zshrc file.

Copy link

sourcery-ai bot commented Jan 30, 2025

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Nidhi091999 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The pull request appears to be missing the actual code changes. Please ensure all intended modifications are included in the commit.
  • Please provide more context in the PR description about what issue fix: source direnv and extension in dev container #65 entails and how these changes resolve it.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@JaeAeich
Copy link
Collaborator

JaeAeich commented Feb 7, 2025

@Nidhi091999 This is a small change. please re create the PR with signed commits, I have bypassed and merged your previous PR, but lets now have signed commit.

@JaeAeich JaeAeich closed this Feb 7, 2025
@Nidhi091999
Copy link
Contributor Author

@Nidhi091999 This is a small change. please re create the PR with signed commits, I have bypassed and merged your previous PR, but lets now have signed commit.

Screenshot from 2025-02-07 16-36-04

@JaeAeich As shown in the screenshot, my commits are signed. If there's anything I might have overlooked, please let me know so I can address it accordingly. Thanks!

@JaeAeich JaeAeich reopened this Feb 11, 2025
Copy link
Collaborator

@JaeAeich JaeAeich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@JaeAeich JaeAeich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaeAeich JaeAeich changed the title sourced asdf and initialized direnv fix: source asdf and initialize direnv Feb 11, 2025
@uniqueg
Copy link
Member

uniqueg commented Mar 5, 2025

@Nidhi091999: Thanks a lot for this! Feel free to go ahead and merge, given that the PR is approved :)

@JaeAeich JaeAeich merged commit e8c1e16 into main Mar 10, 2025
@JaeAeich JaeAeich deleted the nidhi/issue-65 branch March 10, 2025 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: source direnv and extension in dev container
3 participants