-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lint issues #69
Fix lint issues #69
Conversation
Reviewer's Guide by SourceryThis pull request addresses linting issues in the project. It modifies the markdownlint configuration file to enforce stricter rules and updates the GitHub workflow files to improve readability. State diagram for Markdown linting rulesstateDiagram-v2
[*] --> Headings
Headings --> Lists
Lists --> LineLength
LineLength --> Formatting
Formatting --> Links
Links --> [*]
state Headings {
[*] --> IncrementByOne
IncrementByOne --> ATXStyle
ATXStyle --> [*]
}
state Lists {
[*] --> DashStyle
DashStyle --> ConsistentIndent
ConsistentIndent --> [*]
}
state Formatting {
[*] --> NoHardTabs
NoHardTabs --> ProperSpacing
ProperSpacing --> BlankLines
BlankLines --> [*]
}
note right of Headings: ATX style enforced
note right of Lists: Dash (-) for markers
note right of LineLength: 80 chars, excluding code & tables
note right of Links: Required alt text & proper URLs
Flow diagram of the updated PR validation workflowgraph TD
A[PR Event] --> B{Check Event Type}
B -->|opened/reopened/ready_for_review| C[Semantic Title Check]
B -->|edited| D{Title Changed?}
D -->|Yes| C
D -->|No| E[Skip Check]
C --> F[Use semantic-pull-request Action]
style C fill:#f9f,stroke:#333,stroke-width:2px
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Nidhi091999 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider keeping a space after comment hashes (# ) throughout the configuration files - this is a common convention that improves readability
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
we dont have rules like this, I think this is your own formatter;s config, either way closing the PR due to unverfired commits, please make the formatting conform only to the rules defined in the PR. |
Summary by Sourcery
Chores: