-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add delete endpoint #345
feat: add delete endpoint #345
Conversation
Signed-off-by: Pratiksha Sankhe <[email protected]>
This reverts commit 938a7c7.
Signed-off-by: Pratiksha Sankhe <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reviewer's Guide by SourceryThis pull request introduces a new endpoint to delete DRS objects by their ID. The implementation includes the addition of the deleteObject function in the drsAPI.ts file, complete with error handling and JSDoc comments. Corresponding documentation updates have been made in the README.md file to describe the new endpoint and its parameters. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @psankhe28 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider improving error handling in the
deleteObject
function to process the response consistently with other API functions. - Tests for the new delete endpoint functionality are missing. Please add appropriate tests to ensure the feature works as expected.
- For consistency, consider aligning the parameter order in
deleteObject
withpostObject
(i.e.,baseURL
as the first parameter).
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Signed-off-by: Pratiksha Sankhe <[email protected]>
Signed-off-by: Pratiksha Sankhe <[email protected]>
Signed-off-by: Pratiksha Sankhe <[email protected]>
@psankhe28, you can merge when you're ready |
Description
It adds an endpoint to delete the drs object based on the object id
Fixes #(issue)
#333
Checklist
Comments
Summary by Sourcery
Introduce a new endpoint to delete DRS objects by their ID and update the documentation to reflect this new functionality.
New Features:
Documentation: