chore: cleanup #281

anuragxxd · 2024-03-23T10:54:25Z

Description

Fixes #147 #139 #269 #268 #244 #243 #238

Checklist

My code follows the contributing guidelines of this project.
I am aware that all my commits will be squashed into a single commit, using the PR title as the commit message.
I have performed a self-review of my own code.
I have commented my code in hard-to-understand areas.
I have updated the user-facing documentation to describe any new or changed behavior.
My changes generate no new warnings.
I have added tests that prove my fix is effective or that my feature works.
I have not reduced the existing code coverage.

Comments

changeset-bot · 2024-03-23T10:54:28Z

⚠️ No Changeset found

Latest commit: eb7e133

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-03-23T10:54:30Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
cloud-components	❌ Failed (Inspect)			Apr 8, 2024 9:34am

anuragxxd · 2024-03-23T11:16:02Z

Hey @SalihuDickson @JaeAeich, I'd appreciate it if you could take a look at this PR. I've cleaned things up by replacing older packages with their newer counterparts. Since this is a large PR, here are the key areas to focus on:

@SalihuDickson I removed the deprecated dependency from the build script that was causing errors. I also updated the make-react script's component path to address another error. To verify these changes, it would be helpful if you could run the script locally.
@JaeAeich I've made some changes to WES & TES as well. If you have time, it would be great if you could run them locally to ensure they're working as expected.
@JaeAeich We're removing the docs entirely in favor of feat(docs): Nextra docs #262 so there's no need to migrate them. Could you consider updating your PR to use the latest packages?
commit-lint & commit-generator: To streamline our squash & merge strategy, I've removed these from the recommit.

I'm also considering moving TRS & TRS-filer to a legacy folder to deprecate them before migrating them to the lit & design package implementation. What are your thoughts on this approach?

For peace of mind, it would be great if you both could try running the PR locally to check any functionalities it might affect. While I've tested everything myself, more reviews are always valuable. thanks!

JaeAeich

@git-anurag-hub

Please change the license from MIT to Apache 2.0 for individual packages as well (ref).
Please configure the dev server ports to be different they are running on 8000 currently.
Building the package is really unstable and breaks quite often, maybe the clean up before build should fix it.
dev fails if the user hasn't run build, maybe we need to create a custom script that build the dependency of the packages (we can provide our dependecy list or just infer all the deps that have "*"), if they are already built runs the dev else builds the deps and then runs.
husky if we are keeping that, then lets add lint-staged, I mean otherwise I don't see a point of running the test each time I have to commit, yeah would have sense to lint some files (staged).
prettier please can we also configure prettier in this PR itself, only formatting md, mdx, html, css, JSON and other non code files only though. And since this can be added to husky, this might be useful.

packages/ecc-client-elixir-trs-filer/playwright.config.js

package.json

packages/ecc-client-ga4gh-tes/.eslintignore

packages/ecc-client-ga4gh-tes/README.md

packages/ecc-client-ga4gh-tes/package.json

scripts/make-react.js

JaeAeich · 2024-03-23T20:47:06Z

I'm also considering moving TRS & TRS-filer to a legacy folder to deprecate them before migrating them to the lit & design package implementation. What are your thoughts on this approach?

Let's not move them to a different package for the sake of consistency. Instead, we could remove and/or comment out their scripts so that they don't build or run their tests in CI.

JaeAeich · 2024-03-23T20:51:17Z

Also please run npm i and update the lock file. Apart from that, take a look into this #252 either take reference or configure the package acc you in this PR itself.

PS: If so please also make the changes in template files.

SalihuDickson · 2024-03-25T15:04:22Z

@JaeAeich, I'm not sure how much time @git-anurag-hub has on his hands, and this PR looks like it still needs quite a bit of work and testing before it is ready to be merged. To avoid a lot of back and forth, especially considering the size of the PR, I think we should just make PRs to this fixing the issues we notice.

@git-anurag-hub, please correct me if you would prefer we just request changes. I'm just trying to get this out as soon as possible and it seems it would be easier and quicker for you to look through and approve our PRs instead of having to go and make changes and request reviews to start the process all over again.

anuragxxd · 2024-03-27T09:59:57Z

@git-anurag-hub

Please change the license from MIT to Apache 2.0 for individual packages as well (ref).

Please configure the dev server ports to be different they are running on 8000 currently.

Building the package is really unstable and breaks quite often, maybe the clean up before build should fix it.

dev fails if the user hasn't run build, maybe we need to create a custom script that build the dependency of the packages (we can provide our dependecy list or just infer all the deps that have "*"), if they are already built runs the dev else builds the deps and then runs.

husky if we are keeping that, then lets add lint-staged, I mean otherwise I don't see a point of running the test each time I have to commit, yeah would have sense to lint some files (staged).

prettier please can we also configure prettier in this PR itself, only formatting md, mdx, html, css, JSON and other non code files only though. And since this can be added to husky, this might be useful.

@JaeAeich

Sounds good! I've updated the LICENSE files in all individual packages to Apache 2.0.
Seems like all are pointed to the different ports, but still have reconfigured and arranged them more sensibly.
I guess (atleast I hope) this will not be the problem after the refactor is completed. In the meantime, we'll continue investigating and resolving any build-related problems.
I think the better way of this will be for the dev's to start the dev env for the dependencies (not the build) so that they they can leverage features like HMR for better debugging. Meanwhile will explore automating this process by configuring turbo.json, similar to the build command.
Good idea, this is the reason why we have removed most of the pre-commit hooks now to reduce the overhead from the developers but I guess it is not the best idea to use the Github runner minutes for the test & lint scripts.
We can have issue for this!

anuragxxd · 2024-03-27T10:14:28Z

@JaeAeich, I'm not sure how much time @git-anurag-hub has on his hands, and this PR looks like it still needs quite a bit of work and testing before it is ready to be merged. To avoid a lot of back and forth, especially considering the size of the PR, I think we should just make PRs to this fixing the issues we notice.

@git-anurag-hub, please correct me if you would prefer we just request changes. I'm just trying to get this out as soon as possible and it seems it would be easier and quicker for you to look through and approve our PRs instead of having to go and make changes and request reviews to start the process all over again.

Sure @SalihuDickson, while I have addressed most of the issues referenced here. Are there any other issues you think which are left here? If so please let me know. I have tested most of the functionality affected by this PR but want you & @JaeAeich to take a look at the parts where you have worked. Saying this please go ahead & fix the issues that you might think can take less time solving parallely.

JaeAeich · 2024-03-30T00:35:33Z

@anuragxxd for some reason, I can't build the packages propoerly, maybe we need to have discussion on this. Is it working fine on your end. I did get it running but that seems to be an on off thing, its not consistent. I can't be sure the packages will definetely build everytime.

JaeAeich · 2024-03-30T02:57:14Z

@anuragxxd for some reason, I can't build the packages propoerly, maybe we need to have discussion on this. Is it working fine on your end. I did get it running but that seems to be an on off thing, its not consistent. I can't be sure the packages will definetely build everytime.

Please merge the fix and some more cleanup from #285.

JaeAeich

LGTM 🚀

Small PRs from now on please 😮‍💨 🤣 !

Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: salihuDickson <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

packages/ecc-client-ga4gh-tes/package.json

packages/ecc-utils-design/package.json

turbo/generators/template-package/package.json.hbs

packages/ecc-utils-design/package.json

JaeAeich · 2024-04-06T04:09:24Z

LGTM, Everything seems to work on my machine, please resolve the above as you see fit and lets merge 🚀

scripts/build.js

Co-authored-by: salihuDickson <[email protected]>

Signed-off-by: Anurag Gupta <[email protected]>

anuragxxd · 2024-04-08T09:38:45Z

@SalihuDickson @JaeAeich alright, gonna go ahead and merge this if it all looks good to you. have tested the changes on my machine too seems to work fine.

SalihuDickson

lgtm

anuragxxd added 3 commits March 23, 2024 16:18

refactor: clean code

ce8d2af

refac: clean code

f720baa

refac: clean code

2fa495f

vercel bot had a problem deploying to Preview March 23, 2024 10:55 Failure

anuragxxd requested review from JaeAeich and SalihuDickson March 23, 2024 11:16

JaeAeich requested changes Mar 23, 2024

View reviewed changes

This was referenced Mar 25, 2024

fix: remove React generated code and rename generated React dirs #268

Closed

imp(dx): remove precommit hooks #278

Closed

improvements

fbd9aad

vercel bot had a problem deploying to Preview March 27, 2024 09:30 Failure

more improvements

f3caa49

vercel bot had a problem deploying to Preview March 27, 2024 10:03 Failure

fix: cleanup build (#285)

2d25981

vercel bot had a problem deploying to Preview March 30, 2024 17:07 Failure

more improvements

bf6479f

vercel bot had a problem deploying to Preview March 30, 2024 18:26 Failure

more improvements

9a0b732

vercel bot had a problem deploying to Preview March 30, 2024 18:29 Failure

JaeAeich previously approved these changes Mar 30, 2024

View reviewed changes

vercel bot had a problem deploying to Preview March 30, 2024 19:20 Failure

fixed lock

20b6688

vercel bot had a problem deploying to Preview March 30, 2024 19:22 Failure

fixed lock

2c030cf

vercel bot had a problem deploying to Preview March 30, 2024 19:25 Failure

build: fix build issues (#288)

36837bf

Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: salihuDickson <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

vercel bot had a problem deploying to Preview April 6, 2024 03:51 Failure

anuragxxd requested review from JaeAeich and SalihuDickson and removed request for SalihuDickson April 6, 2024 03:54

JaeAeich reviewed Apr 6, 2024

View reviewed changes

packages/ecc-client-ga4gh-tes/package.json Show resolved Hide resolved

packages/ecc-utils-design/package.json Show resolved Hide resolved

turbo/generators/template-package/package.json.hbs Outdated Show resolved Hide resolved

JaeAeich reviewed Apr 6, 2024

View reviewed changes

packages/ecc-utils-design/package.json Outdated Show resolved Hide resolved

chore: format fix

62d20e2

vercel bot had a problem deploying to Preview April 6, 2024 05:14 Failure

JaeAeich reviewed Apr 6, 2024

View reviewed changes

scripts/build.js Outdated Show resolved Hide resolved

chore: fix handlebars

807f2f1

vercel bot had a problem deploying to Preview April 6, 2024 05:32 Failure

Fix: stop modifying packagejson (#290)

b780b58

Co-authored-by: salihuDickson <[email protected]>

vercel bot had a problem deploying to Preview April 8, 2024 07:08 Failure

Update package.json

2ddf8e0

Signed-off-by: Anurag Gupta <[email protected]>

vercel bot had a problem deploying to Preview April 8, 2024 07:09 Failure

Merge branch 'main' into cleanup

60b72df

Signed-off-by: Anurag Gupta <[email protected]>

vercel bot had a problem deploying to Preview April 8, 2024 09:27 Failure

fix lock

eb7e133

vercel bot had a problem deploying to Preview April 8, 2024 09:34 Failure

SalihuDickson approved these changes Apr 8, 2024

View reviewed changes

anuragxxd merged commit 9c88bd4 into main Apr 8, 2024

anuragxxd deleted the cleanup branch April 8, 2024 23:18

chore: cleanup #281

chore: cleanup #281

Uh oh!

Conversation

anuragxxd commented Mar 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Comments

Uh oh!

changeset-bot bot commented Mar 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Mar 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anuragxxd commented Mar 23, 2024

Uh oh!

JaeAeich left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JaeAeich commented Mar 23, 2024

Uh oh!

JaeAeich commented Mar 23, 2024

Uh oh!

SalihuDickson commented Mar 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anuragxxd commented Mar 27, 2024

Uh oh!

anuragxxd commented Mar 27, 2024

Uh oh!

JaeAeich commented Mar 30, 2024

Uh oh!

JaeAeich commented Mar 30, 2024

Uh oh!

JaeAeich left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JaeAeich commented Apr 6, 2024

Uh oh!

Uh oh!

anuragxxd commented Apr 8, 2024

Uh oh!

SalihuDickson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

anuragxxd commented Mar 23, 2024 •

edited

Loading

changeset-bot bot commented Mar 23, 2024 •

edited

Loading

vercel bot commented Mar 23, 2024 •

edited

Loading

JaeAeich left a comment •

edited

Loading

SalihuDickson commented Mar 25, 2024 •

edited

Loading