Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add linter configuration #18

Closed
wants to merge 1 commit into from
Closed

chore: add linter configuration #18

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 13, 2022

Description

Adding prettier configuration file as mentioned in issue#38

Fixes #(issue)

  • My code follows the [contributing guidelines][contributing] of this
    project, including, in particular, with regard to any style guidelines
  • The title of my PR complies with the [Conventional Commits
    specification][conventional-commits]; in particular, it clearly indicates
    that a change is a breaking change
  • I am aware that all my commits will be squashed into a single commit,
    using the PR title as the commit message.
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have updated the user-facing documentation to describe any new or
    changed behavior
  • I have added type annotations for all function/class/method interfaces
    or updated existing ones
  • I have provided [JSDoc][jsdoc] block tags for all
    functions/classes/methods or updated existing ones
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature
    works
  • New and existing unit tests pass locally with my changes
  • I have not reduced the existing code coverage
  • I have asked the [@all-contributors bot][all-contributors-bot] to
    acknowledge my contributions by commenting on this PR with a request of
    the form @all-contributors please add @YOUR_GH_HANDLE for TYPE_1, TYPE_2, ..., where TYPE_1 etc. refer to [contribution types supported
    by the All Contributors Specification][all-contributors-types] OR I do
    not want my contributions to be acknowledged

Signed-off-by: Tanya Kumari <[email protected]>
@anuragxxd
Copy link
Member

Hey @tanya17-05, Thanks for the PR but It will be better if we configure prettier along with the eslint so that they are in sync with each other.

@uniqueg uniqueg changed the title Add prettier configuration chore: add linter configuration Jul 15, 2022
@uniqueg
Copy link
Member

uniqueg commented Jul 15, 2022

I agree with @git-anurag-hub. I have added the PR title accordingly (add lintter configuration). @git-anurag-hub: can you please give @tanya17-05 some pointer as to how to configure ESLint? And if you have any specific requirements/preferences as for the actual configuration, then please let her know, too. @tanya17-05: you can then just add another commit to your branch and the PR should be updated.

@anuragxxd
Copy link
Member

Sure @uniqueg I talked to @tanya17-05 on slack about this. I think it's better to have some initial code in the repo at first this will give us the idea about many thing which will help us set eslint.

@uniqueg
Copy link
Member

uniqueg commented Jul 15, 2022

Yeah, sounds good. But perhaps you could start off with something basic so that we can merge this PR. We can always modify/extend later on

@anuragxxd
Copy link
Member

Yeah, I will init the basic code within next few days.

@uniqueg
Copy link
Member

uniqueg commented Jul 18, 2022

Thanks - please let me know when it's ready to review @git-anurag-hub

@anuragxxd anuragxxd closed this May 6, 2023
@anuragxxd
Copy link
Member

Closing this as this is not needed now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants