-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): run sphinx-apidocs #202
Conversation
Reviewer's Guide by SourceryThis pull request primarily focuses on updating documentation for better readability and consistency, adding new badges to the README, and enhancing the Helm chart configurations with resource limits, security contexts, and updated ingress settings. Additionally, it introduces new API specifications, models, and services for TESK, along with corresponding unit tests and example JSON files. File-Level Changes
Tips
|
#201 should be merged first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose if you remove all the changes in the tesk
package, this PR will probably be good to go once the other stuff is merged, which - as you say - should happen first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs stuff looks fine, but not sure why there are the other files (constants, wrapper, exceptions) in this PR. Just remove it. Then, when #201 is merged, you can just update the branch and all will be fine, I think (or otherwise, merge the updated main
into your feature branch).
Also, not sure about the PR title: I don't see any code that runs the API docs build, but rather only changes to the pages. So shouldn't it be something like docs: add API docs pages
or docs: extend API docs
or something like that?
closing as #201 got this covered. |
Summary by Sourcery
Enhance documentation formatting and readability, add resource limits and security context configurations to Kubernetes templates, update ingress configuration to 'networking.k8s.io/v1', and introduce new unit tests, OpenAPI specification, Python models, Kubernetes client wrapper, taskmaster script, and example input JSON file.
Enhancements:
Documentation:
Tests:
Chores: