Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): cache #178

Merged
merged 7 commits into from
May 24, 2024
Merged

feat(ci): cache #178

merged 7 commits into from
May 24, 2024

Conversation

JaeAeich
Copy link

@JaeAeich JaeAeich commented May 21, 2024

cache invalidation in github actions:

  • use composite actions to reduce redundancy
  • cache pipx installations
  • cache poetry installation

fixes - #174

PS: Roughly 50% reduction in time :) on tests, lint etc.
Edit: upto ~67%.

@JaeAeich
Copy link
Author

PS: not completed and not converting to draft because need to test CI :)

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JaeAeich - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 3 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

.github/workflows/code_quality.yaml Show resolved Hide resolved
.github/workflows/code_quality.yaml Outdated Show resolved Hide resolved
.github/workflows/code_quality.yaml Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (0b81865) to head (7a4cb0b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #178   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files           8        8           
  Lines         559      559           
=======================================
  Hits          549      549           
  Misses         10       10           
Flag Coverage Δ
test_unit 98.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uniqueg
Copy link
Member

uniqueg commented May 21, 2024

PS: not completed and not converting to draft because need to test CI :)

Alright :) Just tag me when it's ready for review

@JaeAeich JaeAeich force-pushed the cache branch 7 times, most recently from 856293c to e4ba4b7 Compare May 23, 2024 11:57
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! I'm on my phone so it's a bit hard to review all details. But since it runs fine, I think it should be good. Two minor things, one maybe an oversight, the other a matter of opinion, I guess.

.github/workflows/code_test_unit.yaml Outdated Show resolved Hide resolved
.github/actions/setup/poetry/action.yaml Show resolved Hide resolved
@JaeAeich JaeAeich requested a review from uniqueg May 24, 2024 04:27
@JaeAeich JaeAeich merged commit cabf21c into main May 24, 2024
13 checks passed
@JaeAeich JaeAeich deleted the cache branch May 24, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants