-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): cache #178
feat(ci): cache #178
Conversation
PS: not completed and not converting to draft because need to test CI :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JaeAeich - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 8 8
Lines 559 559
=======================================
Hits 549 549
Misses 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Alright :) Just tag me when it's ready for review |
856293c
to
e4ba4b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! I'm on my phone so it's a bit hard to review all details. But since it runs fine, I think it should be good. Two minor things, one maybe an oversight, the other a matter of opinion, I guess.
cache
invalidation ingithub actions
:pipx
installationspoetry
installationfixes - #174
PS: Roughly
50%
reduction in time :) on tests, lint etc.Edit: upto
~67%
.