Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency to clusterType #139

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Remove dependency to clusterType #139

merged 1 commit into from
Feb 2, 2024

Conversation

lvarin
Copy link
Contributor

@lvarin lvarin commented Jan 30, 2024

There are two main changes:

  • .Capabilities.APIVersions.Has is used to detect Route, that only openshift has.
  • The new Role has been tweaked to (1) allow config maps to be created and (2) logs can no longer be deleted, but I think it was not used.

It works in OpenShift.

@uniqueg uniqueg requested a review from xhejtman January 30, 2024 13:15
@lvarin
Copy link
Contributor Author

lvarin commented Feb 1, 2024

Tested and works in k3s

xhejtman
xhejtman approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@xhejtman xhejtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvarin lvarin merged commit 38f1389 into master Feb 2, 2024
1 check passed
@lvarin lvarin deleted the delete-clusterType branch February 2, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhejtman xhejtman xhejtman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lvarin @xhejtman