fix: remove sourcery because eww

.github/workflows/pr_evaulations.yaml

@@ -52,19 +52,3 @@ jobs:
         # Find lines containing "<<<<<<<", then count the number of lines.
         # 0 matching lines results in exit code 0, i.e. success.
         run: exit $(git grep "<<<<<<<" ":(exclude).github/" | wc --lines)
-
-  review-with-sourcery:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v3
-        with:
-          fetch-depth: 0
-
-      - uses: actions/setup-python@v4
-        with:
-          python-version: '3.10'
-
-      - uses: sourcery-ai/action@v1
-        with:
-          token: ${{ secrets.SOURCERY_TOKEN }}
-          diff_ref: ${{ github.event.pull_request.base.sha }}

tests/test_unit/service/test_filer.py

@@ -25,8 +25,6 @@
 )
 from tesk.service.filer_s3 import S3Transput
 from tesk.service.path import containerPath
-
-# sourcery skip: dont-import-test-modules
 from tests.test_unit.service.assertThrows import AssertThrowsMixin
 
 

tests/test_unit/service/test_job.py

@@ -226,7 +226,6 @@ def test_run_to_completion_success(
 		"""
 		Checking if the Job runs is completed successfully
 		"""
-		# sourcery skip: no-loop-in-tests
 		for executor in self.data['executors']:
 			jobname = executor['metadata']['name']
 			job = Job(executor, jobname, taskmaster.args.namespace)
@@ -249,7 +248,7 @@ def test_run_to_completion_cancelled(
 		"""
 		Checking if the Job is cancelled
 		"""
-		for executor in self.data['executors']:  # sourcery skip: no-loop-in-tests
+		for executor in self.data['executors']:
 			jobname = executor['metadata']['name']
 			job = Job(executor, jobname, taskmaster.args.namespace)
 			status = job.run_to_completion(
@@ -279,7 +278,7 @@ def test_run_to_completion_check_conflict_exception(
 		"""
 		Checking if the Job status is complete when an ApiException of 409 is raised
 		"""
-		for executor in self.data['executors']:  # sourcery skip: no-loop-in-tests
+		for executor in self.data['executors']:
 			jobname = executor['metadata']['name']
 			job = Job(executor, jobname, taskmaster.args.namespace)
 			status = job.run_to_completion(
@@ -300,7 +299,7 @@ def test_run_to_completion_check_other_K8_exception(
 		Checking if the an exception is raised when ApiException status is other
 		than 409
 		"""
-		for executor in self.data['executors']:  # sourcery skip: no-loop-in-tests
+		for executor in self.data['executors']:
 			jobname = executor['metadata']['name']
 			job = Job(executor, jobname, taskmaster.args.namespace)
 			with self.assertRaises(ApiException):
@@ -333,7 +332,7 @@ def test_run_to_completion_error(  # noqa: PLR0913
 		mock_list_namespaced_pod.return_value = (
 			list_namespaced_pod_error_ImagePullBackOff(10)
 		)
-		for executor in self.data['executors']:  # sourcery skip: no-loop-in-tests
+		for executor in self.data['executors']:
 			jobname = executor['metadata']['name']
 			job = Job(executor, jobname, taskmaster.args.namespace)
 			status = job.run_to_completion(1, taskmaster.check_cancelled, 120)

tests/test_unit/service/test_s3_filer.py

@@ -87,7 +87,7 @@ def test_s3_download_file(moto_boto, path, url, ftype, expected, fs, caplog):  #
 	"""
 	with S3Transput(path, url, ftype) as trans:
 		assert trans.download_file() == expected
-		if expected:  # sourcery skip: no-conditionals-in-tests
+		if expected:
 			assert 'Not Found' in caplog.text
 		else:
 			assert os.path.exists(path) is True
@@ -113,7 +113,7 @@ def test_s3_download_directory(  # noqa: PLR0913
 	with S3Transput(path, url, ftype) as trans:
 		assert trans.download_dir() == expected
 		print(mock_rename.mock_calls)
-		if expected:  # sourcery skip: no-conditionals-in-tests
+		if expected:
 			assert 'Invalid file path' in caplog.text
 		else:
 			"""
@@ -139,7 +139,7 @@ def test_s3_upload_file(moto_boto, path, url, ftype, expected, fs, caplog):  # n
 	trans = S3Transput(path, url, ftype)
 	trans.bucket_obj = client.Bucket(trans.bucket)
 	assert trans.upload_file() == expected
-	if expected:  # sourcery skip: no-conditionals-in-tests
+	if expected:
 		assert 'File upload failed for' in caplog.text
 	else:
 		"""

tests/test_unit/service/test_taskmaster.py

@@ -136,7 +136,6 @@ def test_append_mount(self, mock_logger):
 		""" """
 		volume_mounts = []
 		task_volume_name = 'task-volume'
-		# sourcery skip: no-loop-in-tests
 		for aninput in self.data['inputs']:
 			dirnm = dirname(aninput)
 			append_mount(volume_mounts, task_volume_name, dirnm, self.pvc)