-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Fix: registry auth, Ingress #24
base: dev
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request modifies the Ingress resource to be compatible with the networking.k8s.io/v1 API version, removes the openshift route, and updates the helm chart to use a tls secret. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @akash2237778 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please add a PR description explaining the motivation for removing OpenShift support and simplifying the Ingress configuration. This will help reviewers understand the intended changes and their impact.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -22,7 +22,7 @@ test: ## Runs unit tests and shows coverage. | |||
|
|||
install-pubgrade: # build ## Install pubgrade on cluster using helm. | |||
# kubectl create namespace $(APP_NAME) --dry-run=client -o yaml | kubectl apply -f - | |||
helm upgrade --install $(APP_NAME) deployment/ -n $(APP_NAME) | |||
helm upgrade --install $(APP_NAME) helm/ -n $(APP_NAME)-ns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Namespace mismatch between install and uninstall commands will cause uninstall to fail
The uninstall command uses
Summary by Sourcery
Update the Ingress configuration to use a predefined TLS secret and set the host to pubgrade.dyn.cloud.e-infra.cz. Update helm chart path in Makefile.
Build:
Deployment: