Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Fix: registry auth, Ingress #24

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Conversation

akash2237778
Copy link
Collaborator

@akash2237778 akash2237778 commented Jan 28, 2025

Summary by Sourcery

Update the Ingress configuration to use a predefined TLS secret and set the host to pubgrade.dyn.cloud.e-infra.cz. Update helm chart path in Makefile.

Build:

  • Update the installation path of the helm chart.

Deployment:

  • Configure ingress to use an existing TLS secret.

Copy link

sourcery-ai bot commented Jan 28, 2025

Reviewer's Guide by Sourcery

This pull request modifies the Ingress resource to be compatible with the networking.k8s.io/v1 API version, removes the openshift route, and updates the helm chart to use a tls secret.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
The Ingress resource was updated to be compatible with the networking.k8s.io/v1 API version.
  • Removed the conditional logic for the networking.k8s.io/v1/Ingress API version.
  • Removed the conditional logic for the route.openshift.io/v1/Route API version.
  • Removed the tls configuration from the ingress resource.
  • Added a pathType: Prefix to the ingress resource.
  • Removed the https configuration from the ingress resource.
helm/templates/pubgrade-webserver/ingress.yaml
The helm chart was updated to use a tls secret.
  • Removed the https configuration from the values.yaml file.
  • Added a tlsSecrets configuration to the values.yaml file.
helm/values.yaml
The helm install command was updated to install the chart in a namespace.
  • Updated the helm install command to install the chart in a namespace.
Makefile

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @akash2237778 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please add a PR description explaining the motivation for removing OpenShift support and simplifying the Ingress configuration. This will help reviewers understand the intended changes and their impact.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -22,7 +22,7 @@ test: ## Runs unit tests and shows coverage.

install-pubgrade: # build ## Install pubgrade on cluster using helm.
# kubectl create namespace $(APP_NAME) --dry-run=client -o yaml | kubectl apply -f -
helm upgrade --install $(APP_NAME) deployment/ -n $(APP_NAME)
helm upgrade --install $(APP_NAME) helm/ -n $(APP_NAME)-ns
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Namespace mismatch between install and uninstall commands will cause uninstall to fail

The uninstall command uses $(APP_NAME) namespace while install uses $(APP_NAME)-ns. This will prevent proper cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant